Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node versions #216

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Update node versions #216

merged 2 commits into from
Oct 27, 2023

Conversation

guyroyse
Copy link
Contributor

Fixed failing tests due to node versions, Redis version change

…w values and FT.DROPINDEX throwing an error with different casing, the latter was also a bug
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ffbedb) 78.21% compared to head (cefa774) 77.35%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   78.21%   77.35%   -0.86%     
==========================================
  Files          41       41              
  Lines        3286     3286              
  Branches      732      704      -28     
==========================================
- Hits         2570     2542      -28     
  Misses         42       42              
- Partials      674      702      +28     
Files Coverage Δ
lib/repository/repository.ts 85.04% <0.00%> (-0.30%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sav-norem sav-norem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good to me

@guyroyse guyroyse merged commit 31d7da0 into main Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants