fix: cast from db connections with non decoded output#664
Merged
abrookins merged 3 commits intoredis:mainfrom Apr 9, 2025
Merged
fix: cast from db connections with non decoded output#664abrookins merged 3 commits intoredis:mainfrom
abrookins merged 3 commits intoredis:mainfrom
Conversation
ivanbelenky
changed the title
Contributor
Author
|
@sav-norem @bsbodden (saw slorello in PR #663 tagging you, so Ill repeat the pattern) I am all ears for suggestions &| clarifications on this one |
XChikuX
approved these changes
Dec 12, 2024
XChikuX
left a comment
XChikuX
left a comment
There was a problem hiding this comment.
Faced this issue myself for bytes storage.
I used the same fix in my production code, so Looks Good to Me
Collaborator
|
Let's try it. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
As stated on this issue, the connections objects may be set without decoding. Therefore, the stored hash can be a
bytesobject. This is an issue that clashes withschema_out_of_datefalse positive: different type will force inequality checks to always beTrueIndexMigrationexpectsprevious_hashto be ofstrtypeThis small check and reassignment for
stored_hash, fixes the issue and enables correct detection.