FIX: Add Support for Declaring Vector Fields in JsonModel with Relevant Unit Tests#674
Closed
huwaizatahir2 wants to merge 3 commits intoredis:mainfrom
Closed
FIX: Add Support for Declaring Vector Fields in JsonModel with Relevant Unit Tests#674huwaizatahir2 wants to merge 3 commits intoredis:mainfrom
huwaizatahir2 wants to merge 3 commits intoredis:mainfrom
Conversation
Author
|
Hi @slorello89 @banker @simonprickett @chayim, can we please have a look at this PR, thanks |
Author
|
|
any update? |
Author
@kaidotdev the core team usually seems to be busy with other projects unfortunately. |
Collaborator
|
Seems straightforward! I resolved a merge conflict and will see if the tests pass. |
Collaborator
|
I implemented this in #699 @huwaizatahir2. Tests here weren't passing and I can't push up to this branch |
Collaborator
|
closing for #699 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Reference:
#656
This pull request addresses the inability to declare vector fields in JsonModel, as described in the referenced issue. The following updates are introduced to resolve the issue and enhance functionality:
Fixes
Additions
Unit Tests:
Outcomes