Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS-563: Migration to Conan v2 #83

Merged
merged 50 commits into from
Jan 22, 2025
Merged

RS-563: Migration to Conan v2 #83

merged 50 commits into from
Jan 22, 2025

Conversation

victor1234
Copy link
Collaborator

@victor1234 victor1234 commented Jan 12, 2025 •
edited
Loading

Closes #81

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated (for bug fixes / features / docs)

What kind of change does this PR introduce?

Support of Conan v2

What was changed?

  • Updated the conan API to v2 in conanfile.py
  • Added a with_chrono option to conanfile.py
    • This option is set automatically based on the OS and the compiler
  • Implemented support for building from local sources if the version is not specified
  • Added cmake and python formatters to the pre-commit hooks
  • Updated the CI pipeline to accommodate all the aforementioned changes.

Related issues

#81

Does this PR introduce a breaking change?

No

Other information:

@victor1234 victor1234 changed the title Support for Conan v2 Migration to Conan v2 Jan 19, 2025
@victor1234 victor1234 requested a review from atimin January 19, 2025 19:00
@atimin atimin changed the title Migration to Conan v2 RS-563: Migration to Conan v2 Jan 22, 2025
atimin
atimin approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@atimin atimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I'll only add the JIRA ID to the change log and merge the PR.

@atimin atimin merged commit 17e76a9 into main Jan 22, 2025
14 checks passed
@atimin atimin deleted the reduct-cpp-81 branch January 22, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atimin atimin atimin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support for Conan v2
2 participants
@victor1234 @atimin