fix: Add browser compatibility for Content-Length header restrictions #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atimin
requested changes
Apr 23, 2025
There was a problem hiding this comment.
@hussnainzafar , sorry, this patch doesn't make any sense to me. Why not just stop sending the content-length header when it's 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What was changed?
Modified how Content-Length headers are handled in browser environments:
Added browser detection in Bucket.update, Record.write, and Batch operations
Implemented a read-delete-write approach for label updates in browsers
Added request interceptor to handle Content-Length headers in browsers
Related issues
Related issues
(Add links to related issues)
Does this PR introduce a breaking change?
No, this PR maintains backward compatibility while adding browser support.
Other information:
This fix addresses browser security restrictions that prevent setting the Content-Length header directly, which was causing 422 errors when updating labels in browser environments