-
Notifications
You must be signed in to change notification settings - Fork 1
Add UDP sockets as an alternative to Elixir's Port, helpers for debugging and implement changes on bacnetd with notes #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ivanhercaz
wants to merge
88
commits into
redwirelabs:main
Choose a base branch
from
BACnetTesting:bits-to-redwire
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with proper logger
…plicated code (already in karg/)
Use them with Helper or its alias H.
There is a note in the code for Ed and Abelino.
…bacnet-stack This change is currently locked to our current debugging-testing environment, but at least temporarily it is a good solution to navigate between both directories and setting breakpoints.
…sed by bacnet-stack
…arside network numbers
Author
|
I added two more commits solving the next:
|
Because of how the bacnet-stack works, it is recommended to terminate the `SUPPORTED_OBJECT_TABLE` with a sentinel value that indicates the end. Steve Karg's usual way is to set the last value of the list to a value completely null with the exception of the type in which is set `MAX_BACNET_OBJECT_TYPE`. Co-authored-by: Ed <edward@bac-test.com> (cherry picked from commit 50a6de3)
Author
…k build directory
…of create_analog_input/5
…is not a statement" This error was being given on some switchs statements and produces errors that avoid to compile the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Redwire Labs Team,
I know this PR is a bit huge and it may be splitted into several branches and make pull requests per feature. But at this moment I think the best will be to sync this work. Although I try each commit to be self-explanatory I leave below a summary of the changes done and some important remarks (with important at the beginning):
BACNetUDPmodule simulatesBACNetmodule but using UDP sockets, and there is aBACNetUDP.Helpermodule that eases our debugging, testing and fixing work (it is also aliased in IEx asHandHelper.USE_UDP_SOCKETSinsrc/port.hto choose. I will change it soon. TheUSE_UDP_SOCKETSis used insrc/main.candsrc/port.hto enable them.src/bacnet.cyou can see some changes we have done (mainly pending todos, doubts and the decouple the concept ofbacnet_network_idintobacnet_farside_network_numberandbacnet_nearside_network_number.CMakelists.txtfile is completely different to yours, so we may need to discuss about this.bacnet-stackand the VSCode debugger configuration, we work with the structure of having a directory in which then there are two directories: one is thebacnet_exand the another one is thebacnet-stack. I know it is vendor-locked to our current way to develop, but it isn't mandatory to be done in that way and it is easy to find another way.bacnetdand thebacnet-stacka symbolic link to../bacnet-stackwas added, so only opening thebacnet_exwe can see all the source files.mix.exsI disable the:cmakecompiler because it was causing issues when getting the dependencies from the firmware. Anyway, this change is something it isn't required to be merged in your main unless you find some way of conditional choose it (I have not though about it yet, so prefer to discuss with you).I think I am not forgetting nothing, but if I remember something more I will update this message. Anyway, I keep the pull request as a draft because I want to made some changes, as the one of the configuration of
USE_UDP_SOCKETS, that I probably will do using an environment variable: easy to implement, easy to use.I also wants to sync our branches with the latest from your
main.Regards,
Iván