Add command object #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelino
force-pushed
the
add-command-object
branch
from
1014e7b to
1271ca9
Compare
amclain
approved these changes
Apr 6, 2025
| deps: deps(), | ||
| docs: docs(), | ||
| compilers: [:cmake] ++ Mix.compilers(), | ||
| cmake_env: %{"MAKEFLAGS" => "-j#{nproc()}"}, |
Member
There was a problem hiding this comment.
Should we have an override for this for computers that don't run well when all the cores are maxed?
Contributor
Author
There was a problem hiding this comment.
This project isn't big and shouldn't bog down a low core count system.
Contributor
Author
There was a problem hiding this comment.
In general I think we should have an opt-out mechanism for all projects. By default compilation should use all available cores and the opt-out should allow users to set the number of available cores for compilation.
- Parallel build source code
- Optimize targets for prod releases
- Do not use glob for patches because it won't pick up on file changes
- Simplify how libei is found
- Simplify includes instructions
- Always use $ENV{MIX_APP_PATH}/priv as the out dir regardless of build target
abelino
force-pushed
the
add-command-object
branch
from
1271ca9 to
afc4b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to create Command objects with basic properties. The
bacnetdwill fire events when it receives a Command(ed) change from the BMS. It is the responsibility of the owning process to update the status of the command when appropriate.