Fix invalid object-identifier response for read-property request #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amclain
approved these changes
Apr 10, 2025
When a read-property request is received, the `Device_Read_Property` function processes two common properties: object-identifier and object-type. However, the `property_list_common_encode` function currently uses the default device bacnet_id, which is incorrect in routing scenarios. With this change, if the bacnet-stack is compiled with the `BAC_ROUTING` option, the object-identifier is omitted from the common list, allowing the downstream read-property subroutine to handle it appropriately.
abelino
force-pushed
the
fix-bad-device-object-id
branch
from
39a4e9b to
a254f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a read-property request is received, the
Device_Read_Propertyfunction processes two common properties: object-identifier and object-type. However, theproperty_list_common_encodefunction currently uses the default device bacnet_id, which is incorrect in routing scenarios. With this change, if the bacnet-stack is compiled with theBAC_ROUTINGoption, the object-identifier is omitted from the common list, allowing the downstream read-property subroutine to handle it appropriately.