ci: update Cesium ION token of reearth-cms-web Cloud Run service
#1275
Conversation
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
✅ Deploy Preview for reearth-cms canceled.
|
WalkthroughThe pull request modifies the workflow file Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/cron_ion_token_test.yml (2)
36-41: LGTM with a suggestion: Update Cloud Run step looks good, but consider improving quoting.The change from updating a configuration file to directly updating the Cloud Run service aligns well with the PR objectives. The use of environment variables makes the command more maintainable.
However, to prevent potential issues with word splitting if the token contains spaces, consider wrapping the environment variable value in quotes:
gcloud run services update $CMS_WEB \ - --update-env-vars REEARTH_CMS_CESIUM_ION_ACCESS_TOKEN=${{ steps.ion_token.outputs.token }} \ + --update-env-vars REEARTH_CMS_CESIUM_ION_ACCESS_TOKEN="${{ steps.ion_token.outputs.token }}" \ --region $REGION \ --platform managed🧰 Tools
🪛 actionlint
37-37: shellcheck reported issue in this script: SC2086:info:1:28: Double quote to prevent globbing and word splitting
(shellcheck)
37-37: shellcheck reported issue in this script: SC2086:info:3:12: Double quote to prevent globbing and word splitting
(shellcheck)
Line range hint
1-41: Overall changes look good. Consider updating related documentation.The workflow has been successfully updated to work with a Cloud Run service instead of modifying a configuration file. This aligns well with the PR objectives and should result in a more efficient process for updating the Cesium Ion token.
To ensure smooth operation and maintainability:
- Update any documentation that references the old configuration file update process.
- Verify that no other parts of the system still rely on the removed
reearth_config.jsonfile.- Consider adding a comment in the workflow file explaining the purpose of the monthly token update.
🧰 Tools
🪛 actionlint
20-20: shellcheck reported issue in this script: SC2086:info:15:30: Double quote to prevent globbing and word splitting
(shellcheck)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/cron_ion_token_test.yml (2 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/cron_ion_token_test.yml
37-37: shellcheck reported issue in this script: SC2086:info:1:28: Double quote to prevent globbing and word splitting
(shellcheck)
37-37: shellcheck reported issue in this script: SC2086:info:3:12: Double quote to prevent globbing and word splitting
(shellcheck)
🔇 Additional comments (2)
.github/workflows/cron_ion_token_test.yml (2)
7-8: LGTM: Environment variables added for Cloud Run service.The addition of
CMS_WEBandREGIONenvironment variables is appropriate for the updated workflow that now interacts with a Cloud Run service. These variables will be used in the Cloud Run update command later in the workflow.
13-13: LGTM: Repository checkout step added.The addition of the
actions/checkout@v4step is appropriate. This ensures that the workflow has access to the repository contents, which may be necessary for subsequent steps. Using the latest version (v4) of the action is also a good practice.
Overview
Because now the Re:Earth CMS frontend (web) has been Docker-ized, we must update the environment variables instead of updating the
reearth_config.jsonon GCS.What I've done
What I haven't done
How I tested
I ran the workflow by dispatching the event and confirmed that it's working: log
Screenshot
Which point I want you to review particularly
Memo
Summary by CodeRabbit