💥 Remove default exports #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
force-pushed
the
no-default-export
branch
from
fba2343
to
8d7cfef
Compare
Default exports have [bad interoperability][1] between Common JS and ES Module imports, so the safest thing to do is just remove them. This is a **BREAKING** change which removes our export default statements, and adds a linter rule to prevent us from adding them. [1]: evanw/esbuild#1719 (comment)
alecgibson
force-pushed
the
no-default-export
branch
from
8d7cfef
to
24d10d5
Compare
dawidreedsy
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default exports have bad interoperability between Common JS and ES Module imports, so the safest thing to do is just remove them.
This is a BREAKING change which removes our export default statements, and adds a linter rule to prevent us from adding them.