Open
Conversation
- Updated Babel configuration to use automatic React runtime. - Added Yarn configuration for node modules linking. - Introduced new Points feature with routing and context management. - Added API service for Points-related functionalities. - Included new assets and styles specific to Points. - Updated package.json with new dependencies and versions. - Enhanced webpack configuration for JSX and CSS handling. - Modified index.html to include Google Tag Manager scripts.
…tate - Updated `getLeaderboardPoints` API method to accept pagination parameters (page and limit). - Modified `LeaderboardTable` component to handle pagination and loading state, allowing for dynamic data rendering. - Integrated pagination state management in `HomePage` to manage leaderboard data fetching and display.
- Changed the API endpoint in `getLeaderboardPoints` from `/points/daily-total-points` to `/points/total-points-per-user` to enhance data accuracy and consistency.
- Changed `isLoading` to `loading` in `LeaderboardTable` component for improved clarity. - Updated related references in `HomePage` to align with the new variable name. - Enhanced pagination handling in `fetchDataWithoutAccount` to ensure proper data fetching and state management.
- Bumped qs package from version 6.14.1 to 6.14.2 for improved functionality and security.
- Changed rxjs version from 7.5.7 to 7.5.6 in package.json and yarn.lock to address a conflict with @PolkaDot. - Updated the usage of selectedTokenPrices$ in ContentRouter to bypass TypeScript errors related to the version change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates Points feature into reef-app and enhances leaderboard functionality with pagination and improved data retrieval.
Changes
Notes
Known Issue (Pre-existing)
Fixed RxJS type conflict in
ContentRouter.tsx:56with type assertion. This is a pre-existing issue in master due to RxJS version conflict between main package and@polkadot/api-base. The type definition inReefSigners.ts:24incorrectly showsObservable<never>but should beObservable<TokenWithAmount[]>. This should be fixed separately.Code reference:
ContentRouter.tsx:56- Type assertion workaroundReefSigners.ts:24- Type definition needs update (future fix)