Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly secure /business-metrics endpoint #149

Merged
merged 1 commit into from
Dec 6, 2023
Merged

properly secure /business-metrics endpoint #149

merged 1 commit into from
Dec 6, 2023

Conversation

mjurbanski-reef
Copy link
Contributor

No description provided.

@jsuchan-reef
Copy link
Contributor

properly secure

securing against the well-known path traversal due to missing trailing slash, or something else?

@mjurbanski-reef
Copy link
Contributor Author

@jsuchan-reef

  1. it blocks requests to /business-metrics endpoint from people accessing site by it is proper domain (as checked on nginx level)
  2. it allows access to /business-metrics endpoint only to clients verified by our cert - we use the same auth mechanism for all prometheus endpoint

1&2 are done by two separate virtual host configs in nginx which

@mjurbanski-reef mjurbanski-reef merged commit 1d85534 into master Dec 6, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the expose_business_metric branch December 6, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuchan-reef jsuchan-reef jsuchan-reef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjurbanski-reef @jsuchan-reef