-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT-147 allauth #185
RT-147 allauth #185
Conversation
* refs/heads/master: docker compose install fix in prepare-os.sh skip all lock files in codespell apply ruff UP rules to emailhelper CI should inform if ruff has unsafe fixes available
{{cookiecutter.repostory_name}}/app/src/{{cookiecutter.django_project_name}}/settings.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember allauth has some basic templates which one should always override with custom ones, maybe some custom templates should already be included into cookiecutter? I'm not 100% sure tho.
Also, it allows registration of two types as far as i remember: with sending confirmation email and without it, but here it's not covered at all.
Ideally I would like to have cookiecutter questions be like
- enable registration?
- require email confirmation?
- enable google login?
- enable apple ID login?
- ...
So "adding allauth support" is not about adding it to requirements, INSTALLED_APPS
and including instructions in README but about answering few questions and get everything set up for you. With current PR I still have to do stuff manually.
I don't know what original task was so I have no clue whether what I wrote is valid or not, just my thoughts.
{{cookiecutter.repostory_name}}/app/src/{{cookiecutter.django_project_name}}/settings.py
Show resolved
Hide resolved
{{cookiecutter.repostory_name}}/app/src/{{cookiecutter.django_project_name}}/settings.py
Outdated
Show resolved
Hide resolved
{{cookiecutter.repostory_name}}/app/src/{{cookiecutter.django_project_name}}/settings.py
Outdated
Show resolved
Hide resolved
@agoncharov-reef I agree that this PR doesn't really do much. It feels to me that in general, I don't really know what settings we would prefer to pull up to the cookiecutter options - lots of allauth things can be simply changed via settings.py - email verification etc. The templates are project specific and the included one is not pretty but functional. I'd say there is no need to overwrite them in cookiecutter. Regarding enabling specific providers via cookiecutter options - there are >100 of them. However I see that we probably won't care about most of them ever, so Google / Apple / other popular ones could make sense to be exposed in cookiecutter options - I'll do that. Enabling/disabling signups - I would see this more as a dynamic setting? Could be a part of the constance config. |
I cannot really imagine a case in which you allow autoregistration and do not require email confirmation. |
* refs/heads/master: fix celery logging fix asgi error refresh migration metrics every metrics export
I made this PR a bit more opinionated and took the suggestion from @mjurbanski-reef .
There are a bunch of default settings that will:
I believe this should make it so that you can mostly "just enable allauth" and have a working setup. |
{{cookiecutter.repostory_name}}/app/src/{{cookiecutter.django_project_name}}/urls.py
Outdated
Show resolved
Hide resolved
* refs/heads/master: RT-156 Update psycopg 2.9 -> 3.1, add simple test (#190) make README easier to read # Conflicts: # {{cookiecutter.repostory_name}}/README.md
Intorduces optional integration with django-allauth
(!) new cookiecutter variables:
use_allauth
allauth_trust_external_emails
use_allauth_*
Streamlined config available for providers: