RT-156 Update psycopg 2.9 -> 3.1, add simple test #190
Conversation
This is recommended according to https://pypi.org/project/psycopg-binary/
| @@ -12,6 +12,7 @@ Currently, `cookiecutter-rt-django` has no explicit versioning amd we purely rel | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| * **BREAKING** Update psycopg from 2.9 to 3.1 (https://www.psycopg.org/psycopg3/docs/basic/from_pg2.html) | |||
There was a problem hiding this comment.
is it breaking if we use it strictly through django ORM as well?
There was a problem hiding this comment.
It seems that Django adjusts the behavior (at least settings) to the installed version, so I guess is safe to use with either. I haven't found any problem reports coming from this upgrade from a quick online search. I'll remove this
There was a problem hiding this comment.
it was fine here, but I guess it will be also fine without that line since its verryyy rare we use posrgresql driver features directly
| pytestmark = pytest.mark.django_db | ||
|
|
||
|
|
||
| class DummyValue(models.Model): |
There was a problem hiding this comment.
django has some built-in models, no reason to add one just for this tests
... I'm actually perplexed how this passed the CI without a migration for this dummy model - I was underimpression it would not.
There was a problem hiding this comment.
it seems this only works because there are no migrations in this project
If someone uses this template as is, as soon as they create migrations they will have to debug this broken tests which is not a good experience.
There was a problem hiding this comment.
Ack, now using User model instead
features.md
Outdated
| @@ -9,7 +9,7 @@ | |||
| - [Gunicorn](https://gunicorn.org) for running WSGI instances on prod | |||
| - [Uvicorn](https://www.uvicorn.org) for ASGI instances on prod | |||
| - [Nginx](https://www.nginx.com) as high-performance reverse proxy with automatic SSL certificate renewal | |||
| - [Postgres](https://www.postgresql.org) for database | |||
| - [Postgres](https://www.postgresql.org) with [psycopg](https://www.psycopg.org) for database | |||
There was a problem hiding this comment.
| - [Postgres](https://www.postgresql.org) with [psycopg](https://www.psycopg.org) for database | |
| - [Postgres](https://www.postgresql.org) with [psycopg3](https://www.psycopg.org) for database |
There was a problem hiding this comment.
Updated the link to point to psycopg3 page as well
This logger is only used for the following debug message: couldn't import psycopg 'c' implementation: No module named 'psycopg_c' Disable it in Django settings because it is logged before pytest configures its loggers.
This is logged when psycopg is imported, and uses logging config from Django settings (this happens before pytest configures log capturing). I have disabled this logger, it's only used for this message. |
mjurbanski-reef
merged commit aed226d
into
reef-technologies:master
Uh oh!
There was an error while loading. Please reload this page.