refactor(UserSettingDataSourceImpl): Removed isInitialized field and …

…all corresponding methods.
rees46 · Dec 25, 2024 · ebc2402 · ebc2402
1 parent a405ba7
commit ebc2402
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 41 deletions.
diff --git a/personalization-sdk/src/main/kotlin/com/personalization/RegisterManager.kt b/personalization-sdk/src/main/kotlin/com/personalization/RegisterManager.kt
@@ -20,15 +20,15 @@ import com.personalization.sdk.domain.usecases.preferences.GetPreferencesValueUs
 import com.personalization.sdk.domain.usecases.preferences.SavePreferencesValueUseCase
 import com.personalization.sdk.domain.usecases.userSettings.GetUserSettingsValueUseCase
 import com.personalization.sdk.domain.usecases.userSettings.UpdateUserSettingsValueUseCase
-import java.security.SecureRandom
-import java.util.Date
-import java.util.TimeZone
-import javax.inject.Inject
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 import org.json.JSONObject
+import java.security.SecureRandom
+import java.util.Date
+import java.util.TimeZone
+import javax.inject.Inject
 
 class RegisterManager @Inject constructor(
     private val getPreferencesValueUseCase: GetPreferencesValueUseCase,
@@ -121,7 +121,7 @@ class RegisterManager @Inject constructor(
         lastUpdate: Long
     ): Boolean {
         return autoSendPushToken &&
-            (savedToken.isEmpty() || savedToken != newToken || (currentDate - lastUpdate >= ONE_WEEK_MILLISECONDS))
+                (savedToken.isEmpty() || savedToken != newToken || (currentDate - lastUpdate >= ONE_WEEK_MILLISECONDS))
     }
 
     private fun sendPushTokenToServer(token: String, currentDate: Long) {
@@ -223,7 +223,6 @@ class RegisterManager @Inject constructor(
     }
 
     private fun initializeSdk(seance: String?) {
-        updateUserSettingsValueUseCase.updateIsInitialized(value = true)
         val finalSeance = seance ?: generateOrRetrieveSeance()
         updateUserSettingsValueUseCase.updateSid(value = finalSeance)
         executeQueueTasksUseCase.invoke()

diff --git a/personalization-sdk/src/main/kotlin/com/personalization/SDK.kt b/personalization-sdk/src/main/kotlin/com/personalization/SDK.kt
@@ -32,10 +32,10 @@ import com.personalization.sdk.domain.usecases.userSettings.InitUserSettingsUseC
 import com.personalization.stories.StoriesManager
 import com.personalization.stories.views.StoriesView
 import com.personalization.utils.DomainFormattingUtils.formatApiDomain
-import java.util.Locale
-import javax.inject.Inject
 import org.json.JSONException
 import org.json.JSONObject
+import java.util.Locale
+import javax.inject.Inject
 
 open class SDK {
 
@@ -230,14 +230,7 @@ open class SDK {
         replaceWith = ReplaceWith("getSid(): String")
     )
     fun getSid(listener: Consumer<String?>) {
-        val thread = Thread {
-            listener.accept(getSid())
-        }
-        if (getUserSettingsValueUseCase.getIsInitialized()) {
-            thread.start()
-        } else {
-            addTaskToQueueUseCase.invoke(thread)
-        }
+        listener.accept(getSid())
     }
 
     /**

diff --git a/...rc/main/kotlin/com/personalization/sdk/data/repositories/network/NetworkRepositoryImpl.kt b/...rc/main/kotlin/com/personalization/sdk/data/repositories/network/NetworkRepositoryImpl.kt
@@ -123,7 +123,7 @@ class NetworkRepositoryImpl @Inject constructor(
     private fun sendAsync(sendFunction: () -> Unit) {
         val thread = Thread(sendFunction)
         if (userSettingsRepository.getDid()
-                .isNotEmpty() && userSettingsRepository.getIsInitialized()
+                .isNotEmpty()
         ) {
             thread.start()
         } else {

diff --git a/...n/kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSource.kt b/...n/kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSource.kt
@@ -20,7 +20,4 @@ interface UserSettingsDataSource {
     fun getDid(): String
     fun saveDid(value: String)
     fun removeDid()
-
-    fun getIsInitialized(): Boolean
-    fun setIsInitialized(value: Boolean)
 }
diff --git a/...tlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt b/...tlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
@@ -23,8 +23,6 @@ class UserSettingsDataSourceImpl @AssistedInject constructor(
     @Assisted("stream") private val stream: String
 ) : UserSettingsDataSource {
 
-    private var isInitialized: Boolean = false
-
     override fun addParams(
         params: JSONObject,
         notificationSource: NotificationSource?,
@@ -57,9 +55,4 @@ class UserSettingsDataSourceImpl @AssistedInject constructor(
     override fun getDid(): String = preferencesDataSource.getValue(DID_KEY, DEFAULT_DID)
     override fun saveDid(value: String) = preferencesDataSource.saveValue(DID_KEY, value)
     override fun removeDid() = preferencesDataSource.removeValue(DID_KEY)
-
-    override fun getIsInitialized(): Boolean = isInitialized
-    override fun setIsInitialized(value: Boolean) {
-        isInitialized = value
-    }
 }
diff --git a/...tlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsRepositoryImpl.kt b/...tlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsRepositoryImpl.kt
@@ -52,13 +52,6 @@ class UserSettingsRepositoryImpl @Inject constructor(
     override fun getSidLastActTime(): Long =
         userSettingsDataSource.getSidLastActTime()
 
-    override fun getIsInitialized(): Boolean =
-        userSettingsDataSource.getIsInitialized()
-
-    override fun updateIsInitialized(value: Boolean) {
-        userSettingsDataSource.setIsInitialized(value)
-    }
-
     override fun addParams(
         params: JSONObject,
         notificationSource: NotificationSource?

diff --git a/...sdk/src/main/kotlin/com/personalization/sdk/domain/repositories/UserSettingsRepository.kt b/...sdk/src/main/kotlin/com/personalization/sdk/domain/repositories/UserSettingsRepository.kt
@@ -21,9 +21,6 @@ interface UserSettingsRepository {
     fun updateSidLastActTime()
     fun getSidLastActTime(): Long
 
-    fun getIsInitialized(): Boolean
-    fun updateIsInitialized(value: Boolean)
-
     fun addParams(
         params: JSONObject,
         notificationSource: NotificationSource?,

diff --git a/...otlin/com/personalization/sdk/domain/usecases/userSettings/GetUserSettingsValueUseCase.kt b/...otlin/com/personalization/sdk/domain/usecases/userSettings/GetUserSettingsValueUseCase.kt
@@ -14,6 +14,4 @@ class GetUserSettingsValueUseCase @Inject constructor(
     fun getSid(): String = userSettingsRepository.getSid()
 
     fun getSidLastActTime(): Long = userSettingsRepository.getSidLastActTime()
-
-    fun getIsInitialized(): Boolean = userSettingsRepository.getIsInitialized()
 }
diff --git a/...in/com/personalization/sdk/domain/usecases/userSettings/UpdateUserSettingsValueUseCase.kt b/...in/com/personalization/sdk/domain/usecases/userSettings/UpdateUserSettingsValueUseCase.kt
@@ -12,6 +12,4 @@ class UpdateUserSettingsValueUseCase @Inject constructor(
     fun updateSid(value: String) = userSettingsRepository.updateSid(value)
 
     fun updateSidLastActTime() = userSettingsRepository.updateSidLastActTime()
-
-    fun updateIsInitialized(value: Boolean) = userSettingsRepository.updateIsInitialized(value)
 }