Feat/connect in app notification #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DanielGreenEngineer
commented
Nov 21, 2024
DanielGreenEngineer
commented
- https://github.com/rees46/development/issues/1661
|
Пруфы. |
TorinAsakura
requested changes
Nov 27, 2024
...tion-sdk/src/main/kotlin/com/personalization/api/responses/initialization/WebPushSettings.kt
Outdated
Show resolved
Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/errors/response.error.kt.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/com/personalization/features/inAppNotification/impl/InAppNotificationManagerImpl.kt
Show resolved
Hide resolved
...n/kotlin/com/personalization/features/inAppNotification/impl/InAppNotificationManagerImpl.kt
Show resolved
Hide resolved
...lization-sdk/src/main/kotlin/com/personalization/sdk/data/mappers/SdkInitializationMapper.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/personalization/sdk/domain/usecases/inAppNotification/InAppNotificationUseCase.kt
Outdated
Show resolved
Hide resolved
TorinAsakura
reviewed
Dec 2, 2024
Comment on lines
+8
to
+14
| private val message: String? = null, | ||
| ) { | ||
|
|
||
| fun logError() { | ||
| Log.e( | ||
| /* tag = */ tag, | ||
| /* msg = */ "Error caught in $functionName : $message" | ||
| /* msg = */ "Field is empty or null in $functionName : $message" |
There was a problem hiding this comment.
фиговый паттерн, так как пустое поле и nulled - разные состояния, это две разные ошибки, постарайся всегда декомпозировать такое состояние
TorinAsakura
reviewed
Dec 2, 2024
| message = "Error mapping CloseAction", | ||
| exception = exception | ||
| ) | ||
| null |
There was a problem hiding this comment.
возвращать null - один из древнейших антипаттернов, подумай над этим в будущем
TorinAsakura
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.