Refactor/adding data sources abstractions #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
looee1q
commented
Dec 18, 2024
looee1q
commented
- https://github.com/rees46/development/issues/1510
looee1q
force-pushed
the
refactor/adding-data-sources-abstactions
branch
from
c0a92e5 to
007b80d
Compare
|
@TorinAsakura В ходе работы над этой таской выявил следующие моменты, которые хотелось бы подстветить. Они же служат обоснованием почему я написал код именно так.
Дополнительно еще вынес два момента в дисуссии для обсуждения. |
|
TorinAsakura
requested changes
Dec 24, 2024
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
…all corresponding methods.
Logic from UserSettingsDataSource moved directly into UserSettingsRepository. All basic user parameters (shop_id, seance, segment, did, sid) goes through SharedPreferences.
looee1q
force-pushed
the
refactor/adding-data-sources-abstactions
branch
from
0d60144 to
ba83c2b
Compare
Logic from UserSettingsDataSource moved directly into UserSettingsRepository. All basic user parameters (shop_id, seance, segment, did, sid) goes through SharedPreferences.
# Conflicts: # personalization-sdk/src/main/kotlin/com/personalization/SDK.kt # personalization-sdk/src/main/kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsDataSource.kt # personalization-sdk/src/main/kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsRepositoryImpl.kt # personalization-sdk/src/main/kotlin/com/personalization/sdk/domain/repositories/UserSettingsRepository.kt # personalization-sdk/src/main/kotlin/com/personalization/sdk/domain/usecases/userSettings/GetUserSettingsValueUseCase.kt
TorinAsakura
requested changes
Jan 10, 2025
.../kotlin/com/personalization/sdk/data/repositories/userSettings/UserSettingsRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
… into separate Util property
TorinAsakura
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.