Open
Conversation
Owner
|
hi, thanks for contributing. i intentionally did not include a search bar in re-start because i believe it is redundant. when you open a new tab you are already focused on the browser's search bar so there is no point in adding a secondary search bar. it would be quite difficult to try to build a search bar that is equivalent or better than the browser's search bar, as you would have to implement things like search suggestions. i need some convincing on why this should be added. |
Owner
|
also, it seems like you've polluted this pr with some personal customizations like font and default settings changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love the theme and the look but I thought it was missing a search bar, so I made a fork and added one. I tried to keep everything the same, same CSS, same basic structure. I also added in some settings for setting which search engine you use.
Overall added: search bar, settings for choosing search engine