fix(core): correct useCustom return type during loading #7109
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed result.data to return undefined instead of empty object while loading - Updated type to CustomResponse<TData>[data] | undefined - Added test to verify undefined data during loading state Resolves #7088
🦋 Changeset detectedLatest commit: 010654f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3 tasks
refine
|
||||||||||||||||||||||||||||
| Project |
refine
|
| Branch Review |
fix/use-custom-return-value-and-type
|
| Run status |
|
| Run duration | 18m 49s |
| Commit |
|
| Committer | Alican Erdurmaz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
22
|
Skipped
|
0
|
Passing
|
265
|
| View all changes introduced in this branch ↗︎ | |
Member
Author
|
closed in favor of #7110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The
useCustomhook returns an empty object ({}) forresult.datawhile loading, but the TypeScript type indicates it'sCustomResponse<TData>["data"]. This causes TypeScript to miss runtime errors when accessing properties or methods onresult.datawithout proper null checks.For example, when expecting an array, calling
result.data.map()fails at runtime withresult.data.map is not a function.What is the new behavior?
Now
result.datareturnsundefinedwhile loading with the correct typeCustomResponse<TData>["data"] | undefined. This forces developers to use proper null checks likeresult.data?.map(), preventing runtime errors.fixes #7088
Notes for reviewers
useCustom.tsEMPTY_OBJECTfallback in favor of returningundefinedresult.dataisundefinedduring loading state