remove hack and pass proper const for position

reflex-dev · Dec 13, 2024 · 444e970 · 444e970
1 parent daa1f0c
commit 444e970
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/reflex/.templates/jinja/web/pages/stateful_component.js.jinja2 b/reflex/.templates/jinja/web/pages/stateful_component.js.jinja2
@@ -5,15 +5,15 @@ export function {{tag_name}} () {
   {{ hook }}
   {% endfor %}
 
-  {% for hook, data in component._get_all_hooks().items() if not data.position or data.position == positions.PRE_TRIGGER %}
+  {% for hook, data in component._get_all_hooks().items() if not data.position or data.position == hook_positions.PRE_TRIGGER %}
   {{ hook }}
   {% endfor %}
 
   {% for hook in memo_trigger_hooks %}
   {{ hook }}
   {% endfor %}
 
-  {% for hook,data in component._get_all_hooks().items() if data.position and data.position == positions.POST_TRIGGER %}
+  {% for hook,data in component._get_all_hooks().items() if data.position and data.position == hook_positions.POST_TRIGGER %}
   {{ hook }}
   {% endfor %}
 

diff --git a/reflex/compiler/templates.py b/reflex/compiler/templates.py
@@ -45,6 +45,7 @@ def __init__(self) -> None:
             "on_load_internal": constants.CompileVars.ON_LOAD_INTERNAL,
             "update_vars_internal": constants.CompileVars.UPDATE_VARS_INTERNAL,
             "frontend_exception_state": constants.CompileVars.FRONTEND_EXCEPTION_STATE_FULL,
+            "hook_positions": constants.Hooks.HookPosition,
         }
 
 

diff --git a/reflex/components/component.py b/reflex/components/component.py
@@ -24,7 +24,6 @@
 )
 
 import reflex.state
-from reflex import constants
 from reflex.base import Base
 from reflex.compiler.templates import STATEFUL_COMPONENT
 from reflex.components.core.breakpoints import Breakpoints
@@ -2169,7 +2168,6 @@ def _render_stateful_code(
             tag_name=tag_name,
             memo_trigger_hooks=memo_trigger_hooks,
             component=component,
-            positions=constants.Hooks.HookPosition,
         )
 
     @staticmethod