-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External assets #3220
Merged
Merged
External assets #3220
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ce72c31
feat: wip rx.asset
abulvenz 40bd7ab
fix: Removed test exception. Using contemporary cwd.
abulvenz 3cb68c3
fix: Adding much logic to provide a nice API for the caller.
abulvenz 38c127d
fix: cleaning up comments.
abulvenz c4929ec
fix: The pipeline made me do this.
abulvenz 73e5a04
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz 3806aec
feat: Review comments. Built in symlinks on non-Windows.
abulvenz 4b80aa4
fix: Using contemporary python libraries.
abulvenz 76cf9d7
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz 592ef9a
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz 8cbd3af
feat: Added test. Moving function to _x namespace.
abulvenz 2bc36f9
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz 381b732
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz 69b8037
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz f46c3c8
fix: Fixing typing for python 3.8 in hooks.
abulvenz 635e701
fix: Fixing typing for python 3.8 in hooks.
abulvenz a758e33
fix: Fixing typing for python 3.8 in client_state.
abulvenz 627c91b
fix: Just saw it was alpha-sorted before.
abulvenz c5cc4c1
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz ca09e38
fix: Removing superficial Path constructor and inlining variable.
abulvenz 9972a35
Merge remote-tracking branch 'upstream/main' into external-assets
abulvenz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Adding much logic to provide a nice API for the caller.
- Loading branch information
commit 3cb68c3fbb77963682cb10f3e483268a1f9ca361
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a variable for
Path(Path(cwd) / assets / external / dir)
first and use it in the next lines. Also check if the source exists with pathlib's.resolve()
methodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lendemor I hope you are fine with using symlinks here, since we are not linking directories. That seems to be the only difference. https://docs.python.org/3/library/pathlib.html#pathlib.Path.symlink_to
@benedikt-bartscher I just tested what happens when
src_file
is not present. It already complainsNo such file or directory
. OK, or wrap it into a anAssetNotPresent
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abulvenz awesome, if there is already a
FileNotFound
exception, I think we are fine, no additional wrapping neededThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abulvenz Sorry for delay in review, was on break for a few days.
It's passing windows CI so it should be fine I think.
I'm not sure about adding it inside
app.py
however, so could you move it to it's own file? Maybe insidereflex/experimental
so we'll get some time to test it in real situations before making it official.We'll also need to add unit tests for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Lendemor, After v0.5.0 everybody earned a small break 🚀 . I will move it to experimental and try to add a unit test.