Layout property not pushed through on rx.plotly #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix itself looks fine, but the tests need to be patched up |
masenf
reviewed
May 28, 2024
Co-authored-by: Masen Furer <m_github@0x26.net>
this allows the data to be passed directly as a figure or from a state var
masenf
reviewed
May 31, 2024
masenf
reviewed
May 31, 2024
masenf
reviewed
May 31, 2024
masenf
approved these changes
May 31, 2024
benedikt-bartscher
pushed a commit
to benedikt-bartscher/reflex
that referenced
this pull request
Jun 3, 2024
* init fix * Update reflex/components/plotly/plotly.py Co-authored-by: Masen Furer <m_github@0x26.net> * plotly: treat `data` as a `dict`-type Var in _render this allows the data to be passed directly as a figure or from a state var * removed width height prop as they are no longer needed * updated * reverted some of the changes * fixed unit tests * regen pyi --------- Co-authored-by: Hongyu Yao <hongyuyao@hongyus-mbp-3.lan> Co-authored-by: Masen Furer <m_github@0x26.net> Co-authored-by: Hongyu Yao <hongyuyao@Hongyus-MacBook-Pro-3.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Now both data and layout prop are supported in Plotly figures.