[REF-2978] Ignore Redis config_set for AWS ElastiCache #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS ElastiCache redis has out of band configuration and cannot call CONFIG commands, so allow the user to ignore errors as an escape hatch. Fix #3371
reflex/state.py
Outdated
| ) | ||
| except ResponseError: | ||
| # Some redis servers only allow out-of-band configuration, so ignore errors here. | ||
| ignore_config_error = os.environ.get("REFLEX_AWS_ELASTICACHE_REDIS", None) |
There was a problem hiding this comment.
not sure but this issue might not be exclusive to AWS. not sure what the GCP/Azure implementation of Redis looks like but maybe it's similar. Maybe a more 'general' env var name would be better?
picklelo
approved these changes
May 31, 2024
benedikt-bartscher
pushed a commit
to benedikt-bartscher/reflex
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS ElastiCache redis has out of band configuration and cannot call CONFIG commands, so allow the user to ignore errors as an escape hatch.
Fix #3371