-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF-3328] Implement __getitem__ for ArrayVar #3705
Merged
adhami3310
merged 26 commits into
main
from
khaleel/ref-3328-implement-__getitem__-for-arrayvar
Jul 30, 2024
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
47c5e0d
half of the way there
adhami3310 825e86a
implement __getitem__ for array
adhami3310 f5670ad
add some tests
adhami3310 23c8882
add fixes to pyright
adhami3310 63b80d6
fix default factory
adhami3310 1035c34
implement array operations
adhami3310 a983714
format code
adhami3310 e5efaef
fix pyright issue
adhami3310 3ff130f
give up
adhami3310 cfdf44c
add object operations
adhami3310 e7b2dfa
add test for merge
adhami3310 9181225
pyright 🥺
adhami3310 376fc40
use str isntead of _var_name
adhami3310 ea0b677
wrong var_type
adhami3310 6551fac
make to much nicer
adhami3310 0036e92
add subclass checking
adhami3310 622d836
enhance types
adhami3310 4f5f9e5
use builtin list type
adhami3310 041d421
improve typing even more
adhami3310 e9fa2de
i'm awaiting october
adhami3310 026a49e
use even better typing
adhami3310 8a38603
add hash, json, and guess type method
adhami3310 18bf8cd
fix pyright issues
adhami3310 40b8b87
add a test and fix lots of errors
adhami3310 7c5e9db
fix pyright once again
adhami3310 a196514
add type inference to list
adhami3310 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the
json()
method intended to be used for?