Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more rx.script props #3725

Closed
wants to merge 2 commits into from
Closed

Add more rx.script props #3725

wants to merge 2 commits into from

Conversation

ElijahAhianyo
Copy link
Contributor

This PR updates the props for rx.script.
ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script

@ElijahAhianyo ElijahAhianyo marked this pull request as draft July 31, 2024 14:39
@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review July 31, 2024 14:40
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think these props are recognized by the next/script <Script> element... https://nextjs.org/docs/pages/api-reference/components/script

@ElijahAhianyo
Copy link
Contributor Author

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script

I see, I might have been looking into the wrong rx.script, these props probably belong to rx.el.script, Ill go ahead and close this for now

@masenf masenf deleted the elijah/script-props branch December 12, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants