-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component as Var type #3732
Merged
Merged
Component as Var type #3732
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
cdf6234
[WiP] Support UI components returned from a computed var
masenf 31018de
Get rid of nasty react hooks warning
masenf 92dd6ba
include @babel/standalone in the base to avoid CDN
masenf 9efda81
put window variables behind an object
adhami3310 31eac81
Merge branch 'main' into feat/dynamic-components
adhami3310 eae47dc
use jsx
adhami3310 b74c024
implement the thing
adhami3310 350ccc3
cleanup dead test code (#3909)
benedikt-bartscher 80e5972
override dict in propsbase to use camelCase (#3910)
adhami3310 9139a3b
[REF-3562][REF-3563] Replace chakra usage (#3872)
ElijahAhianyo 76307dc
[ENG-3717] [flexgen] Initialize app from refactored code (#3918)
masenf 454a098
Remove Pydantic from some classes (#3907)
adhami3310 c465741
Merging
adhami3310 f350988
fixss
adhami3310 4b003c3
Merging
adhami3310 2a025dd
fix field_name
adhami3310 6508e30
always import react
adhami3310 e2ab4b8
move func to file
adhami3310 5ac0828
do some weird things
adhami3310 0d6fd78
Merging
adhami3310 49dca79
it's really ruff out there
adhami3310 c7f9c60
add docs
adhami3310 b813d77
how does this work
adhami3310 343eee7
dang it darglint
adhami3310 9ad3213
merging
adhami3310 afae7be
fix the silly
adhami3310 e64a5f2
don't remove computed guy
adhami3310 e0cbd3e
silly goose, don't ignore var types :D
adhami3310 dc033e3
update code
adhami3310 d5d2d4e
put f string on one line
adhami3310 d497e64
make it deprecated instead of outright killing it
adhami3310 cc1784a
i hate it
adhami3310 b1380c8
add imports from react
adhami3310 20e4c36
merging
adhami3310 7822f2b
assert it has evalReactComponent
adhami3310 21bceaf
do things ig
adhami3310 ef377f6
move get field to global context
adhami3310 4e84d64
ooops
adhami3310 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this import all the radix components all the time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In this PR we are not using radix that is stored in the
window
. I assume loading it there takes some additional time (sadly, not sure if there's any way of doing this dynamically).