Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bun version and install script from ovensh #3735

Closed
wants to merge 2 commits into from

Conversation

gunungpw
Copy link

@gunungpw gunungpw commented Aug 2, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution, will test it out further.

MIN_VERSION = "0.7.0"
MIN_VERSION = "1.1.21"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why bump the MIN_VERSION?

i think these older versions will continue to work fine for users who already have them installed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the minimal version need to be 1.1.0, this version officially support windows.
the previous version don't support windows fully.
And some older version have many bug that critical, like make the terminal hang, or just don't work out with many popular js framework.
As this message the newest version is 1.1.22 with speed-up for loading module in windows.
I Think as the bun upstream still try to chase compatibility with NodeJS especially for windows machine, so regularly update the MAX version it very necessary for the fix they do.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://bun.sh/blog/bun-v1.1 the blog for the announcement of supporting windows

change the MIN version to `1.1.10` and MAX version to `1.1.22`
@Lendemor
Copy link
Collaborator

Marking this as Draft until resynced with main.

@Lendemor Lendemor marked this pull request as draft October 25, 2024 18:17
@adhami3310
Copy link
Member

closing this due to inactivity, feels free to resurrect it when appropriate 👍

@adhami3310 adhami3310 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants