-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fully migrate vars into new system #3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
de1fbdb
fully migrate vars into new system
adhami3310 1eecd1f
i hate rufffff (no i don't)
adhami3310 450610a
fix silly pright issues (except colormode and state)
adhami3310 da95d0f
remove all instances of Var.create
adhami3310 c397cb2
create immutable callable var and get rid of more base vars
adhami3310 81cd679
implement hash for all functions
adhami3310 ea33c39
get reflex-web to compile
adhami3310 982e4c1
get it to compile reflex-web successfully
adhami3310 f6938cf
fix tests
adhami3310 0ae8831
fix pyi
adhami3310 4349d69
use override from typing_extension
adhami3310 854d729
put plotly inside of a catch
adhami3310 e0c4e97
dicts are unusable sadly
adhami3310 5bfc0c0
fix silly mistake
adhami3310 0fd4237
overload equals to special case immutable var
adhami3310 2c26dad
improve test_cond
adhami3310 2f49ce0
solve more CI issues, down to 94 failures
adhami3310 82a3498
down to 20 errors
adhami3310 39bc0c0
down to 13 errors
adhami3310 d516b3b
pass all testcases
adhami3310 e92218d
fix pyright issues
adhami3310 1d45f70
reorder things
adhami3310 777e8bc
use get origin more
adhami3310 75ef773
use fixed_type logic
adhami3310 8de75b7
various optimizations
adhami3310 1603e06
go back to passing test cases
adhami3310 9e1a35f
use less boilerplate
adhami3310 ab63e57
remove unnecessary print message
adhami3310 5a8ca04
remove weird comment
adhami3310 9deda27
add test for html issue
adhami3310 0ad21fe
add type ignore
adhami3310 4978b20
fix another silly issue
adhami3310 3d7ea37
override get all var data for var operations call
adhami3310 69f0d1d
make integration tests pass
adhami3310 85c1590
fix immutable call var
adhami3310 dd13dba
better logic for finding parent class
adhami3310 397683a
use even better logic for finding state wrt computedvar
adhami3310 bf1d052
only choose the ones that are defined in the same module
adhami3310 9fb4b67
small dict to large dict
adhami3310 26002a8
[REF-3591] Remove chakra-related files from immutable vars PR (#3821)
masenf 02def8c
Merge branch 'main' into immutable-vars
masenf 7d7f788
pyproject.toml: bump to 0.6.0a1
masenf 8b51244
pyproject.toml: depend on reflex-chakra>=0.6.0a
masenf f09d2e2
Merge remote-tracking branch 'origin/main' into immutable-vars
masenf 56f278d
poetry.lock: relock dependencies
masenf 86563b6
integration: bump listening timeout to 1200 seconds
masenf a94eedf
integration: bump listening timeout to 1800 seconds
masenf 650aa1b
Use cached_var_no_lock to avoid ImmutableVar deadlocks (#3835)
masenf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.