Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message and TypeError for invalid route in App class #3786

Conversation

elviskahoro
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

Copy link
Contributor Author

elviskahoro commented Aug 12, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @elviskahoro and the rest of your teammates on Graphite Graphite

@elviskahoro elviskahoro force-pushed the elvis/lint-typing_collections-reflex_app branch from 956b75e to 20abbe0 Compare August 13, 2024 19:32
@elviskahoro elviskahoro force-pushed the elvis/BANDIT-B404-asserting_component_is_callable branch from 4c1636f to 46ea52a Compare August 13, 2024 19:32
@elviskahoro elviskahoro force-pushed the elvis/lint-typing_collections-reflex_app branch from 20abbe0 to 483d814 Compare August 13, 2024 20:54
@elviskahoro elviskahoro force-pushed the elvis/BANDIT-B404-asserting_component_is_callable branch from 46ea52a to 601cfb8 Compare August 13, 2024 20:55
@elviskahoro elviskahoro force-pushed the elvis/BANDIT-B404-asserting_component_is_callable branch from 601cfb8 to 5d682af Compare August 13, 2024 21:47
@elviskahoro elviskahoro changed the base branch from elvis/lint-typing_collections-reflex_app to elvis/trunk-security August 13, 2024 21:47
@elviskahoro
Copy link
Contributor Author

@ElijahAhianyo going to temporarily close since match case came out in Python 3.10

@tgberkeley tgberkeley closed this Aug 15, 2024
@masenf masenf deleted the elvis/BANDIT-B404-asserting_component_is_callable branch December 12, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants