Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.13 #4206

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Support python 3.13 #4206

merged 6 commits into from
Dec 12, 2024

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Oct 21, 2024

Upstream issue is blocking support for Windows psycopg2.

Reflex is already technically usable for 3.13, we just won't have the CI to guarantee it or catch issues.

Converted to Draft until upstream is fixed.

@Lendemor Lendemor changed the title Update lockfile to work with python 3.13 Support python 3.13 Oct 21, 2024
picklelo
picklelo previously approved these changes Oct 21, 2024
@Lendemor Lendemor marked this pull request as draft October 21, 2024 17:36
@adhami3310
Copy link
Member

blocked on psycopg/psycopg2#1736 which is blocked on appveyor/ci#3927

@benedikt-bartscher
Copy link
Contributor

@Lendemor this is great!
btw, just to let you know: we are using reflex with python3.13 and psycopg3 for a while now, without any issues

@Lendemor
Copy link
Collaborator Author

@Lendemor this is great! btw, just to let you know: we are using reflex with python3.13 and psycopg3 for a while now, without any issues

Thanks for that feedback. Maybe we can go ahead with this then.

@Lendemor Lendemor marked this pull request as ready for review November 26, 2024 18:26
adhami3310
adhami3310 previously approved these changes Nov 26, 2024
masenf
masenf previously approved these changes Nov 26, 2024
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. was able to re-deploy https://rx-shout.mooo.com with py3.13, 0.6.6a2, and psycopg3 👍

@Lendemor Lendemor dismissed stale reviews from masenf and adhami3310 via de50050 December 11, 2024 19:10
@masenf masenf merged commit 5e026e4 into main Dec 12, 2024
41 checks passed
@masenf masenf deleted the lendemor/support_python_3_13 branch December 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants