Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload cancellation #4527

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix upload cancellation #4527

merged 2 commits into from
Dec 12, 2024

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Dec 12, 2024

Cancelling uploads has been broken for a while, but the test wasn't good enough to notice 😔

Make the test better, but now it fails.

So have to make the code better 😄.

Instead of using a special non-exported object to store the upload controller references, just throw them in refs ball with everything else.

@picklelo picklelo merged commit 2d9849e into main Dec 12, 2024
41 checks passed
@picklelo picklelo deleted the masenf/fix-upload-cancel-ref-idea branch December 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants