fix: unwrap MutableProxy values in _mark_dirty before writing#6148
fix: unwrap MutableProxy values in _mark_dirty before writing#6148benedikt-bartscher wants to merge 2 commits intoreflex-dev:mainfrom
Conversation
Merging this PR will degrade performance by 3.02%
Performance Changes
Comparing |
Greptile SummaryFixed a bug where The fix adds a new static method
The unwrapping is applied in Testing:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 18488dd |
|
@benedikt-bartscher what is the use case / bug fixed by this patch? Is there a problem if the data structures get proxy objects added to them? When serializing to redis, we don't serialize the proxy objects, so they get refreshed each time the state is reloaded for processing another event. Also noticed that if the args is a mutable proxy of a list that contains other mutable proxy as items, then these items will not be unwrapped, not sure if that was intentional or not. |
|
@masenf MutableProxy caused issues with sqlalchemy realtions. If i have spare time for it, i may add a unit test with sqlalchemy |
No description provided.