Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the compatibility issue with loading WATM-Go in WATER-rs #37

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

erikziyunchi
Copy link
Member

Solve this issue: refraction-networking/watm#2

Copy link
Contributor

@gaukas gaukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, looks good to me!

crates/water/src/runtime/core.rs Outdated Show resolved Hide resolved
@gaukas
Copy link
Contributor

gaukas commented Mar 6, 2024

Seems code format check doesn's like it 😅

Is there a way to automate the formatting update on saving a .rs file? (Like how VS Code works with gofmt on save).

@erikziyunchi
Copy link
Member Author

Is there a way to automate the formatting update on saving a .rs file? (Like how VS Code works with gofmt on save).

Good point, I should search this out. It would be nice to have that feature similar to what Go has.

@erikziyunchi erikziyunchi merged commit ddbe25c into main Mar 6, 2024
6 checks passed
@erikziyunchi erikziyunchi deleted the fix-go-watm-compatibility-bug branch March 6, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants