Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-269 update user menu and profile edit sidebar with orders #2486

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Sep 26, 2024

Description

https://regennetwork.atlassian.net/browse/APP-269


Author Checklist

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2486--regen-storybook.netlify.app/?path=/story/marketplace-organisms-adminnavigation--default
  2. https://deploy-preview-2486--regen-marketplace.netlify.app/profile/edit/my-orders

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit de86721
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/67090ccca9716a0008d66193
😎 Deploy Preview https://deploy-preview-2486--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph r41ph requested a review from blushi September 30, 2024 12:10
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. A few small details.

On mobile, on profile edit/settings, there's still the back button that doesn't lead anywhere, we should just remove it

image

Also some icon in the menu are not showing up:

image

@r41ph r41ph force-pushed the feat-APP-269-update-user-menu-and-profile-edit-sidebar-with-orders branch from b6e42bb to 2ab767a Compare October 1, 2024 08:49
@r41ph r41ph requested a review from blushi October 1, 2024 09:17
@r41ph r41ph force-pushed the feat-APP-269-update-user-menu-and-profile-edit-sidebar-with-orders branch from 4104212 to ceaaef4 Compare October 3, 2024 09:27
@r41ph r41ph requested a review from blushi October 3, 2024 11:49
@r41ph r41ph force-pushed the feat-APP-269-update-user-menu-and-profile-edit-sidebar-with-orders branch from 2feb15a to 989910e Compare October 7, 2024 09:59
@r41ph r41ph requested a review from blushi October 7, 2024 10:10
@blushi
Copy link
Member

blushi commented Oct 9, 2024

@erikalogie could you have a look at this?

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r41ph r41ph force-pushed the feat-APP-269-update-user-menu-and-profile-edit-sidebar-with-orders branch from 989910e to d6c8364 Compare October 9, 2024 11:21
@erikalogie
Copy link
Collaborator

Looks like something is failing, let me know when it is back up to test

@r41ph
Copy link
Contributor Author

r41ph commented Oct 9, 2024

@erikalogie this is ready for review. There was an issue between the new Accounts Orders page and this feature that required some more updates.
Please note:

  • The implementation of the new accounts orders page has made the dashboard wider, so have a look as well at the 'Settings' and 'Edit profile' pages as they both look wider now and they have no white background anymore like in new 'Orders' page design.
  • 'My prefinance projects' and 'Email updates' don't have page yet.
  • The 'Orders' page is currently under '/profile/edit' not just '/profile' as discussed. This will be amend in a different issue. I have updated the testing instructions with a link to the orders page.

@blushi after these changes you may want to have a look again

@r41ph r41ph requested a review from blushi October 9, 2024 14:49
@erikalogie
Copy link
Collaborator

We discussed a few things about the layout on slack, but also let's do the "P" in "Edit profile" as lower case and the same with the O in "My orders"

@r41ph
Copy link
Contributor Author

r41ph commented Oct 11, 2024

@erikalogie this is ready for another look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants