feat: APP-360 redirect to project buy after google login #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
r41ph
commented
Oct 3, 2024
blushi
reviewed
Oct 7, 2024
Comment on lines
6
to
7
| createProject: boolean = false, | ||
| buyCreditsFrom?: string, |
There was a problem hiding this comment.
since we're adding more custom redirect routes, maybe we should just refactor this to take an optional redirectRoute as param?
There was a problem hiding this comment.
Sounds good to me, passing redirectRoute as a param definitely makes sense!
There was a problem hiding this comment.
This comment now should be:
<LoginFlow
isModalOpen={isModalOpen}
onModalClose={onModalClose}
wallets={walletsUiConfig}
modalState={modalState}
# New prop:
redirectRoute={`${projectHref}/buy`}
/>
r41ph
force-pushed
the
feat-APP-360-redirect-after-google-login
branch
from
deb922c
to
0cac65c
Compare
|
Maybe let's wait on #2477 to be merged before merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://regennetwork.atlassian.net/browse/APP-360
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...