Added intial testing

pytest.ini

@@ -0,0 +1,2 @@
+[pytest]
+addopts = -p no:warnings

rever/environ.xsh

@@ -31,16 +31,19 @@ def detype_logger(x):
 ENVVARS = {
     'REVER_VCS': ('git', is_string, str, ensure_string, "Name of version control "
                   "system to use, such as 'git' or 'hg'"),
-    'LOGGER': (Logger('/tmp/rever.log'), always_false, to_logger, detype_logger,
+    'REVER_DIR': ('rever', is_string, str, ensure_string, 'Path to directory '
+                  'used for storing rever temporary files.'),
+    'LOGGER': (Logger('rever.log'), always_false, to_logger, detype_logger,
                "Rever logger object. Setting this variable to a string will "
-               "change the filename of the logger.")
+               "change the filename of the logger."),
     }
 
 
 def setup():
     for key, (default, validate, convert, detype, docstr) in ENVVARS.items():
         ${...}._defaults[key] = default
-        ${...}._ensurers[key] = Ensurer(validate=validate, convert, detype)
+        ${...}._ensurers[key] = Ensurer(validate=validate, convert=convert,
+                                        detype=detype)
         ${...}._docs[key] = VarDocs(docstr=docstr)
 
 

rever/logger.xsh

@@ -1,4 +1,5 @@
 """Logging tools for rever"""
+import os
 import json
 import time
 import argparse
@@ -16,10 +17,11 @@ class Logger:
         Parameters
         ----------
         filename : str
-            Path to logfile.
+            Path to logfile, if a realtive pathname is given it is relative to $REVER_DIR.
         """
-        self.filename = filename
+        self._filename = None
         self._argparser = None
+        self.filename = filename
 
     def log(self, message, activity=None, category='misc'):
         """Logs a message, teh associated activity (optional), the timestamp, and the
@@ -38,6 +40,20 @@ class Logger:
             entries = [json.loads(line) for line in f]
         return entries
 
+    @property
+    def filename(self):
+        value = self._filename
+        if not os.path.isabs(value):
+            value = os.path.join($REVER_DIR, value)
+        dname = os.path.dirname(value)
+        if not os.path.isdir(dname):
+            mkdir -p @(dname)
+        return value
+
+    @filename.setter
+    def filename(self, value):
+        self._filename = value
+
     @property
     def argparser(self):
         """Returns an argument parser for the logger"""

tests/conftest.py

@@ -0,0 +1,28 @@
+import os
+import shutil
+import tempfile
+import subprocess
+
+import pytest
+
+from rever import environ
+
+
+@pytest.fixture
+def gitrepo(request):
+    """A test fixutre that creates and destroys a git repo in a temporary directory"""
+    cwd = os.getcwd()
+    name = request.node.name
+    repo = os.path.join(tempfile.gettempdir(), name)
+    if os.path.exists(repo):
+        shutil.rmtree(repo)
+    subprocess.run(['git', 'init', repo])
+    os.chdir(repo)
+    with open('README', 'w') as f:
+        f.write('testing ' + name)
+    subprocess.run(['git', 'add', '.'])
+    subprocess.run(['git', 'commit', '-am', 'Initial readme'])
+    with environ.context():
+        yield repo
+    os.chdir(cwd)
+    shutil.rmtree(repo)

tests/test_logger.py

@@ -0,0 +1,11 @@
+"""Tests logger"""
+import os
+
+from rever.logger import Logger
+
+
+def test_logger(gitrepo):
+    logger = Logger(os.path.join(gitrepo, 'mylog.json'))
+    logger.log('sample message', activity="kenny", category="loggin'")
+    entries = logger.load()
+    assert len(entries) == 1