compiler-rt: alu: add remainder for i8 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the following polyfill: - `__llvm_urem_i8_i8` Signed-off-by: Wojciech Zmuda <zmuda.w@gmail.com>
Implement the following polyfill: - `__llvm_srem_i8_i8` The implementation is done by extending the existing sdiv implementation by the calculation of a remainder and then using that division-with-reminder calculation for both `__llvm_srem_i8_i8` and `__llvm_sdiv_i8_i8` to avoid code duplication. Signed-off-by: Wojciech Zmuda <zmuda.w@gmail.com>
wzmuda
force-pushed
the
wz/8b-arith-rem
branch
from
fe6d88f to
3c2a57a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the following polyfills:
__llvm_urem_i8_i8__llvm_srem_i8_i8Details
sremis basicallysdivwith an extra step so I abstracted division with remainder to a separate function and both polyfills are implemented with it.Checklist
scarb fmt.