Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): Update kotlin to 1.9 #587

Merged
merged 4 commits into from
Dec 27, 2023
Merged

fix(deps): Update kotlin to 1.9 #587

merged 4 commits into from
Dec 27, 2023

Conversation

sdsantos
Copy link
Collaborator

@sdsantos sdsantos changed the title Update kotlin to 1.9 fix(deps): Update kotlin to 1.9 Nov 28, 2023
@gnarea
Copy link
Member

gnarea commented Nov 28, 2023

@sdsantos, were all .kt files changed by ktlint? Just wondering if I need to write anything in there

@sdsantos
Copy link
Collaborator Author

@sdsantos, were all .kt files changed by ktlint? Just wondering if I need to write anything in there

Yup, most were whitespace changes made by ktlint. You can hide those changes from the "Files changes" tab to save your the trouble:

Screenshot 2023-11-28 at 16 13 27

gnarea
gnarea previously approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@gnarea gnarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@sdsantos sdsantos added the automerge Allow kodiak to automerge commit when all checks pass label Dec 12, 2023
gnarea
gnarea reviewed Dec 26, 2023
View reviewed changes
app/build.gradle Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit c0d46d5 into master Dec 27, 2023
7 checks passed
@kodiakhq kodiakhq bot deleted the kotlin-1.9 branch December 27, 2023 17:17
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.4.43 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnarea gnarea gnarea approved these changes

Assignees
No one assigned
Labels
automerge Allow kodiak to automerge commit when all checks pass released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdsantos @gnarea