Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Temporarily skip broken tests for cargo relay in the server #611

Merged
merged 1 commit into from
Jul 30, 2024
Merged

chore: Temporarily skip broken tests for cargo relay in the server #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/src/test/java/tech/relaycorp/cogrpc/server/CogRPCServerCollectCargoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import org.junit.jupiter.api.AfterEach
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Assertions.assertFalse
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
import tech.relaycorp.cogrpc.server.DataFactory.buildDeliveryAck
import tech.relaycorp.relaynet.CargoDeliveryRequest
Expand All @@ -27,6 +28,7 @@ internal class CogRPCServerCollectCargoTest {
}

@Test
@Disabled("See PR #610")
internal fun `collectCargo with correct CCA and all cargo acked`() =
runBlockingTest {
setupAndStartServer()
Expand Down Expand Up @@ -110,6 +112,7 @@ internal class CogRPCServerCollectCargoTest {
}

@Test
@Disabled("See PR #610")
internal fun `collectCargo without ack`() {
setupAndStartServer()

Expand Down
2 changes: 2 additions & 0 deletions app/src/test/java/tech/relaycorp/cogrpc/server/CogRPCServerDeliveryCargoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import io.grpc.internal.testing.StreamRecorder
import kotlinx.coroutines.test.runBlockingTest
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
import tech.relaycorp.cogrpc.server.DataFactory.buildDelivery
import tech.relaycorp.relaynet.cogrpc.CargoDeliveryAck
Expand All @@ -16,6 +17,7 @@ import java.nio.charset.Charset

internal class CogRPCServerDeliveryCargoTest {
@Test
@Disabled("See PR #610")
internal fun `deliverCargo with ack when successfully`() =
runBlockingTest {
val mockService = MockCogRPCServerService()
Expand Down
Loading