Skip to content

Rename variables to avoid conflicts with Python builtin function #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hluk merged 1 commit into from
Jan 6, 2026
Merged

Rename variables to avoid conflicts with Python builtin function #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions tests/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
summary: test
"""
DUMMY_ISSUE_FIELDS = {"summary": "test"}
INPUT = "ProductPagesReleases('rhel-10.0')"
RULE_INPUT = "ProductPagesReleases('rhel-10.0')"


def call_run(*, oidc_token_url: str | None = None, additional_jira_fields: dict = {}):
Expand Down Expand Up @@ -111,12 +111,12 @@ def mock_update_state(context):
prerequisites=[PrerequisiteRule(rule=rule_dependency.name)]
)
report = call_run()
inputs = ("rhel-9.0", "rhel-10.0")
releases = ("rhel-9.0", "rhel-10.0")
assert report.data == {
"inputs": [
{
"type": "ProductPagesReleases",
"release": input,
"release": release,
"rules": [
{
"rule": rule_dependency.name,
Expand Down Expand Up @@ -145,7 +145,7 @@ def mock_update_state(context):
},
],
}
for i, input in enumerate(inputs, start=1)
for i, release in enumerate(releases, start=1)
]
}
assert len(condition_prereq.update_state.mock_calls) == 2
Expand Down Expand Up @@ -1008,7 +1008,7 @@ def test_run_rule_template_error_in_prerequisite(factory):
}
assert report.errors == [
dedent(f"""
{INPUT}
{RULE_INPUT}
Rule({rule1.name!r})
Condition('bad_template_variable')
{expected_error}
Expand All @@ -1017,9 +1017,9 @@ def test_run_rule_template_error_in_prerequisite(factory):


def test_run_rule_template_error_in_input(factory):
input = Mock(spec=JiraIssues)
input.values.side_effect = TemplateError("FAILED")
factory.new_rule(inputs=[input])
rule_inputs = Mock(spec=JiraIssues)
rule_inputs.values.side_effect = TemplateError("FAILED")
factory.new_rule(inputs=[rule_inputs])
report = call_run()
assert report.errors == [
dedent("""
Expand All @@ -1030,9 +1030,9 @@ def test_run_rule_template_error_in_input(factory):


def test_run_rule_http_error_in_input(factory):
input = Mock(spec=JiraIssues)
input.values.side_effect = ConnectTimeout("FAILED")
factory.new_rule(inputs=[input])
rule_inputs = Mock(spec=JiraIssues)
rule_inputs.values.side_effect = ConnectTimeout("FAILED")
factory.new_rule(inputs=[rule_inputs])
report = call_run()
assert report.errors == [
dedent("""
Expand All @@ -1043,9 +1043,9 @@ def test_run_rule_http_error_in_input(factory):


def test_run_rule_input_error(factory):
input = Mock(spec=JiraIssues)
input.values.side_effect = InputValuesError("FAILED")
factory.new_rule(inputs=[input])
rule_inputs = Mock(spec=JiraIssues)
rule_inputs.values.side_effect = InputValuesError("FAILED")
factory.new_rule(inputs=[rule_inputs])
report = call_run()
assert report.errors == [
dedent("""
Expand Down Expand Up @@ -1105,7 +1105,7 @@ def update_state(self, context):
}
assert report.errors == [
dedent(f"""
{INPUT}
{RULE_INPUT}
Rule({rule.name!r})
Dummy('')
{expected_error["msg"]}
Expand Down