Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dx #7

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Improve dx #7

merged 4 commits into from
Dec 5, 2023

Conversation

kasperg
Copy link
Member

@kasperg kasperg commented Dec 5, 2023

No description provided.

Hopefully this will make it easier for developers to spot that there is
a prompt regarding port usage.
This is useful for developers who only need to work on CMS and design
system.
This ensures that we do not keep any docker containers running for
developers who do not want/use them.

Sources/generates ensures that nothing is installed needlessly.

Instead we run dev:reset when starting cms development. This also means
that we have to move cms:link from a dependecy to a command since we
cannot ensure that we have a running CMS instance beforehand.

This also means that we have to start the CMS for development explicitly
when running tests. We do not use dev:* commands here as they start
running watch processes. Instead we run their subtasks individually.

Since there is no reset anymore we cannot test it either.
This removes the need for adding a separate command line argument when
running these tasks.
@kasperg kasperg merged commit 2c165a1 into main Dec 5, 2023
1 check passed
@kasperg kasperg deleted the improve-dx branch December 5, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant