-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to make input data available for externals. Dont stop on missing validation data. #1828
Conversation
…found. This file cannot be published to external users. However, since is not required for the execution of REMIND (only for compareScenarios), external users should still be able to run the model even without the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you run make test?
Will there be meaningfull info if downloading inptu data fails?
Yes. All tests pass in
The following chunk, that is always part of the logfile, contains a message. A warning with the same message is printed at the end. Is that enough? The log:
The warning:
|
Purpose of this PR
Add a public repository to the list of input data repositories that are checked at startup. This public repo will contain the input data of the releases, except the validation.tgz, since we are not allowed to publish it. Thus, add the possibility to make individual input data files optional, in this case the validation.tgz. REMIND will not stop if these input data files are missing.
Type of change
Checklist:
CHANGELOG.md
has been updated correctly