Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve checkProjectSummations for NGFS + ELEVATE + ScenarioMIP #1848

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • allow to pass more than one mapping
  • specify whether bunkers units should be ignored dependent on mapping (TRUE for AR6 only)
  • check all mappings for missing variables

Type of change

  • Minor feature improvement

Checklist:

  • No code affects the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • not needed: I checked that the in-code documentation is up-to-date
  • not needed: I adjusted the reporting in remind2
  • not needed: I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • All automated model tests pass (FAIL 0 in the output of make test)
  • not needed: The changelog CHANGELOG.md has been updated correctly

@orichters orichters merged commit 7033bb1 into remindmodel:develop Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants