Improve AgnosticBaseRouteObject type for projects using exactOptionalPropertyTypes#14585
Improve AgnosticBaseRouteObject type for projects using exactOptionalPropertyTypes#14585AsamK wants to merge 2 commits intoremix-run:devfrom
Conversation
…PropertyTypes Projects that use typescript with the exactOptionalPropertyTypes=true setting see a type error when using react-router. The workaround of using skipLibCheck=false is not desirable as it weakens type-system accuracy for the whole project. https://www.typescriptlang.org/tsconfig/#skipLibCheck Fixes remix-run#10392 Fixes remix-run#11991 Fixes remix-run#14504
|
|
Hi @AsamK, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
2 participants
Projects that use typescript with the exactOptionalPropertyTypes=true setting see a type error when using react-router.
The workaround of using skipLibCheck=false is not desirable as it weakens type-system accuracy for the whole project. https://www.typescriptlang.org/tsconfig/#skipLibCheck
This PR makes the minimal changes to work for projects using exactOptionalPropertyTypes=true and would be immensely helpful
Fixes #10392
Fixes #11991
Fixes #14504