Skip to content

fix: handle undefined children in isSameRoute for sibling layouts #14788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scott-memco wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −2
Open

fix: handle undefined children in isSameRoute for sibling layouts #14788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa85a4f
fix: handle undefined children in isSameRoute for sibling layouts
st-imdev Feb 8, 2026
904d43a
chore: sign CLA
st-imdev Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@
- yuleicul
- yuri-poliantsev
- zeevick10
- scott-memco
- zeromask1337
- zheng-chuang
- zxTomw
10 changes: 8 additions & 2 deletions packages/react-router/lib/router/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5378,10 +5378,16 @@ function isSameRoute(
return true;
}

// If only one side has children, they're different routes (e.g., sibling
// layouts where one has been patched with children and the other hasn't)
if (!newRoute.children?.length || !existingRoute.children?.length) {
return false;
}

// Otherwise, we look to see if every child in the new route is already
// represented in the existing route's children
return newRoute.children!.every((aChild, i) =>
existingRoute.children?.some((bChild) => isSameRoute(aChild, bChild)),
return newRoute.children.every((aChild) =>
existingRoute.children!.some((bChild) => isSameRoute(aChild, bChild)),
);
}

Expand Down