Added component property to NavLink #5497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new component property determines which react component a NavLink will render. It defaults to Link, to retain current behavior when omitted. The property can be used if the user wants to change the rendered component, for example when they want to apply a higher order component to Link, or to render something completely different. Updated docs and added a new test case.
|
Thanks for the PR, @Nimelrian. I don't think we want to support rendering anything other than a |
|
So wrapping Link in HOC works, but wrapping NavLink doesn't. Not very intuitive. Are there any known workarounds (that don't involve rewriting NavLink)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new component property determines which React component a NavLink
will render. It defaults to Link, to retain current behavior when omitted.
The property can be used if the user wants to change the rendered
component, for example when they want to apply a higher order component
to Link, or to render something completely different.
Updated docs and added a new test case.
Fixes #5496