Skip to content

Commit

Permalink
Update test to reflect charset-normalizer updates
Browse files Browse the repository at this point in the history
We don't pin charset-normalizer versions, so this test is likely to
flake as changes are made to that library.

- charset-normalizer 3.2.0 reports this encoding as cp037.
- charset-normalizer 3.3.0 reports it as CP949.
- charset-normalizer 3.3.1 and 3.3.2 report it as Big5.

Perhaps we don't care what the value is here. Should we remove this
test? Or, perhaps change it to assert that the encoding is not utf-8?
  • Loading branch information
harto committed Nov 23, 2023
1 parent c3afb13 commit 276c056
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/test_utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def test_empty_df():
[
(b"abcde", "utf-8"), # straight up ascii is a subset of unicode
(b"Eyjafjallaj\xc3\xb6kull", "utf-8"), # actual unicode
(b"\xC4pple", "cp037"), # non-unicode, ISO characterset
(b"\xC4pple", "Big5"), # non-unicode, ISO characterset
],
)
def test_detect_encoding(test_string, encoding):
Expand Down

0 comments on commit 276c056

Please sign in to comment.