This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Extend ML Testing #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1/model-training into feat/a4-ml-testing
cactusutcac
requested review from
github-bowen,
kanta8864,
raghavtalwar7 and
zeri27
…1/model-training into feat/a4-ml-testing
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
github-bowen
approved these changes
May 25, 2025
Member
github-bowen
left a comment
github-bowen
left a comment
There was a problem hiding this comment.
Looks good and comprehensive!
Comment on lines
+48
to
+58
| - name: Install DVC | ||
| run: pip install dvc[gdrive] | ||
|
|
||
| - name: Set up GDrive credentials for DVC | ||
| run: | | ||
| echo "${{ secrets.GDRIVE_JSON_BASE64 }}" | base64 --decode > gdrive-creds.json | ||
| dvc remote modify storage --local gdrive_use_service_account true | ||
| dvc remote modify storage --local gdrive_service_account_json_file_path gdrive-creds.json | ||
|
|
||
| - name: Pull data and models from DVC | ||
| run: dvc pull |
Member
There was a problem hiding this comment.
Nice fix! I forgot to add this back after changing the authentication method to service account
zeri27
approved these changes
May 26, 2025
Contributor
zeri27
left a comment
zeri27
left a comment
There was a problem hiding this comment.
Great work! Well structured and well tested!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.