Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to url.URL, updates and audit #107

Merged
merged 13 commits into from
Dec 30, 2023
Merged

Switch to url.URL, updates and audit #107

merged 13 commits into from
Dec 30, 2023

Conversation

silverbucket
Copy link
Member

@silverbucket silverbucket commented Dec 29, 2023 •
edited
Loading

  • Update node versions: 18, 20, 21
  • Run linting before tests
  • Update mocha due to security vulnerability
  • Run npm audit fix
  • Remove eslint-plugin-standard
  • Set eslint to fail on linting warnings
  • Fix linting warnings
  • Make use of url.URL which securely handles path traversals and means we no longer need to protect against it.

Resolves #72 and for context #31

@silverbucket silverbucket marked this pull request as draft December 29, 2023 18:20
@silverbucket silverbucket marked this pull request as ready for review December 29, 2023 19:57
@silverbucket silverbucket self-assigned this Dec 29, 2023
@silverbucket silverbucket changed the title Catch all eslint warnings, run audit Switch to url.URL, updates and audit Dec 29, 2023
DougReeder
DougReeder reviewed Dec 30, 2023
View reviewed changes
lib/armadietto.js Outdated Show resolved Hide resolved
DougReeder
DougReeder approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@DougReeder DougReeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it will be nice to not see the warnings about urls anymore!

@silverbucket silverbucket merged commit 85e9e46 into master Dec 30, 2023
3 checks passed
@silverbucket silverbucket deleted the old-code-smell branch December 30, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougReeder DougReeder DougReeder approved these changes

@raucao raucao Awaiting requested review from raucao

Assignees

@silverbucket silverbucket

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead"
2 participants
@silverbucket @DougReeder