Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all authenticated apps for a user on their account page #47

Closed
wants to merge 2 commits into from

Conversation

AngeloR
Copy link

@AngeloR AngeloR commented May 20, 2021

I added a new "Account" link in the header that allows users to view
all the apps that they've approved on their armadietto server. It will
prompt them to log in with their username/password and then it will
display:

  • Their account name (username@host)
  • A table of all their approved apps, with info about what permissions
    it has requested

The link appears regardless of the signup option to allow the server
manager to view their data.

Screen Shot 2021-05-18 at 5 10 10 PM

Fixes: #44

I added a new "Account" link in the header that allows users to view
all the apps that they've approved on their armadietto server. It will
prompt them to log in with their username/password and then it will
display:
- Their account name (username@host)
- A table of all their approved apps, with info about what permissions
  it has
@AngeloR
Copy link
Author

AngeloR commented Jun 22, 2021

Bumping on this

@raucao
Copy link
Member

raucao commented Jun 23, 2021

@silverbucket Had a chance to get back into the code yet?

@silverbucket
Copy link
Member

I have been pretty busy with some other high priority work and have had to put a lot of stuff on hold the past few months. So I'm sorry to say, I still haven't had a chance to even start with this. I'll try to get to it as soon as I can, possibly this weekend- but no promises yet.

@silverbucket silverbucket self-requested a review June 25, 2021 12:56
@raucao
Copy link
Member

raucao commented Jan 12, 2022

I had a look at this in a browser today (haven't reviewed any code yet).

There's one thing that immediately stood out to me: I was able to see the authorizations on the new account page, but there's no button to revoke any of them. I have not used Armadietto (or reStore) with real data before, so I don't really know what the feature set is. Is it possible that users are currently not able to revoke authorizations at all?

I also found a minor bug with the favicons: when it cannot find one, there's just a line of big text above the domain name.

There's also a small layout issue with the permissions column: when the category name is too long, the text breaks line and looks a bit awkward.

@AngeloR
Copy link
Author

AngeloR commented Jan 14, 2022

I wasn't sure what the PR/submission process was for such a large change. I'm definitely open to working on it because it's definitely functionality that should be present.

I can update the issue with more information and take it from there.

@raucao
Copy link
Member

raucao commented Jan 15, 2022

I think there is currently no official process for PRs. It would be nice if one or two people could commit to being the official maintainers of this repo/server in order to manage pull requests as well as any other contributions. (I'm not that person. I merely saw PRs coming in over a longer timeframe, with no progress towards merging them. So I took the liberty of triaging a bit and trying to move things forward.)

/cc @lesion @thornjad

@raucao
Copy link
Member

raucao commented Jan 15, 2022

I'm definitely open to working on it because it's definitely functionality that should be present.

I think if users can see the authorizations that exist, it's almost a required feature for an RS server that they can revoke the authorization on that screen as well. So yeah, I would propose to add that in the same PR if possible.

@raucao
Copy link
Member

raucao commented Aug 16, 2022

@AngeloR Hey there. Are you still planning to work on this PR again? Seems to me like there's not that much to add for it to be ready to merge...

@stokito
Copy link
Contributor

stokito commented Jan 22, 2023

The PR is important and you can just merge it even if it's not ideal. Later others may send PRs with more features like revoking and big fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Approved app listing
4 participants